update CommandLineUtils #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmds
reviewed
Nov 19, 2024
tmds
reviewed
Nov 19, 2024
| @@ -234,7 +234,7 @@ class CodeGenArguments | |||
| public string OutputFileName { get; set; } | |||
| public IEnumerable<string> SkipInterfaces { get; set; } | |||
| public Dictionary<string, string> Interfaces { get; set; } | |||
| public List<string> Files { get; set; } | |||
| public IReadOnlyList<string> Files { get; set; } | |||
There was a problem hiding this comment.
The List doesn't work with the McMaster.Extensions.CommandLineUtils's package?
How did you find out?
There was a problem hiding this comment.
Compiler reports:
Cannot implicitly convert type 'System.Collections.Generic.IReadOnlyList<string?>' to 'System.Collections.Generic.List<string>'. An explicit conversion exists (are you missing a cast?)
There was a problem hiding this comment.
|
@tibel the tool has no tests. Did you do some manual verification? |
tibel
force-pushed
the
update-CommandLineUtils
branch
from
35afe20 to
5b47c3b
Compare
I ran some commands on a Raspberry Pi to check if the behavior hasn't changed. |
tibel
force-pushed
the
update-CommandLineUtils
branch
from
5b47c3b to
7fb65ea
Compare
|
lgtm, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://natemcmaster.github.io/CommandLineUtils/docs/intro.html#relationship-to-microsoftextensionscommandlineutils